From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
Date: | 2014-11-12 15:15:56 |
Message-ID: | 20141112151556.GA13995@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-11-12 10:13:18 -0500, Robert Haas wrote:
> On Tue, Nov 11, 2014 at 4:27 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > The more important thing here is that I see little chance of this
> > getting in before Heikki's larger rework of the wal format gets
> > in. Since that'll change everything around anyay I'm unsure how much
> > point there is to iterate till that's done. I know that sucks, but I
> > don't see much of an alternative.
>
> Why not do this first? Heikki's patch seems quite far from being
> ready to commit at this point - it significantly increases WAL volume
> and reduces performance. Heikki may well be able to fix that, but I
> don't know that it's a good idea to make everyone else wait while he
> does.
Because it imo builds the infrastructure to do the compression more
sanely. I.e. provide proper space to store information about the
compressedness of the blocks and such.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-11-12 15:20:33 | Re: Race condition between hot standby and restoring a FPW |
Previous Message | Heikki Linnakangas | 2014-11-12 15:14:00 | Re: Race condition between hot standby and restoring a FPW |