Re: ALTER TABLESPACE MOVE command tag tweak

Alvaro,

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> Stephen Frost wrote:
> > * Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> > > ALTER TABLE ALL IN TABLESPACE xyz
> > > which AFAICS should work since ALL is already a reserved keyword.
> >
> > Pushed to master and REL9_4_STABLE.
>
> Thanks. One more tweak --- the whole reason for fiddling with this is
> to ensure that event triggers support this operation. Therefore this
> node should be handled by ProcessUtilitySlow, not
> standard_ProcessUtility, as in the attached patch.

Ah, right, of course. I recall looking for what else might need to be
changed and apparently missed that distinction in the call sites.

> (I checked the documentation for necessary updates; turns out that the
> table in the event triggers chapter says that ddl_command_end etc
> support the command "ALTER TABLE", and since this is the tag returned by
> the new ALTER TABLE ALL IN TABLESPACE command, there is no update
> needed. In fact, one can argue that the table is wrong currently
> because it doesn't say that ALTER TABLE ALL IN TABLESPACE is not
> supported.)

Heh, yes, true.

> I propose this for 9.4 too.

Agreed. Looks pretty straight-forward, will update soon.

> > Apologies on it taking so long-
> > things have a bit "interesting" for me over the past month or two. :)
>
> I bet they have! Have fun,

Thanks! :)

Stephen