| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Thomas Munro <munro(at)ip9(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Cluster name in ps output |
| Date: | 2014-06-26 07:05:03 |
| Message-ID: | 20140626070503.GC15586@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2014-06-25 16:13:19 +0900, masao(dot)fujii(at)gmail(dot)com wrote:
>
> Categorizing this parameter to CONN_AUTH_SETTINGS looks strange to me
Oh yes. Sorry, I meant to respond to this point in my original review,
but forgot. Yes, CONN_AUTH_SETTINGS is just weird. But I couldn't find
an obviously better answer either.
LOGGING_WHAT would work with log_line_prefix support, but I don't think
there was as much support for that version of this patch. I personally
don't have a strong opinion about whether it's worth adding an escape.
> STATS_COLLECTOR also looks a bit strange not only for cluster_name but
> also update_process_title, though...
True. Is UNGROUPED the only answer?
> monitoring.sgml explains PS display. Isn't it better to update
> monitoring.sgml so that it refers to cluster_name?
Good point.
-- Abhijit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-06-26 07:07:42 | Re: psql: show only failed queries |
| Previous Message | Samrat Revagade | 2014-06-26 06:22:54 | Re: psql: show only failed queries |