Re: Useless "Replica Identity: NOTHING" noise from psql \d

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date: 2014-03-27 13:10:48
Message-ID: 20140327131048.GA11694@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 27, 2014 at 10:02:20AM +0100, Christoph Berg wrote:
> Re: Bruce Momjian 2014-03-26 <20140326161056(dot)GA468(at)momjian(dot)us>
> > The attached patch matches your suggestion. It is basically back to
> > what the code originally had, except it skips system tables, and shows
> > "???" for invalid values.
>
> Fwiw, "make check-world" is currently broken:

Yes, the patch was partial to just show the code changes, to get
approval. Attached is the full patch.

I did some research of the regression database to see what was being
set:

SELECT relreplident, relkind, nspname, count(*)
FROM pg_class, pg_namespace
WHERE relkind IN ('m', 'r') AND
relnamespace = pg_namespace.oid AND
nspname != 'pg_catalog'
GROUP BY relreplident, nspname, relkind
ORDER BY 1, 2, 3;

relreplident | relkind | nspname | count
--------------+---------+--------------------+-------
d | m | mvschema | 1
d | m | public | 5
d | r | information_schema | 7
d | r | public | 205
d | r | testxmlschema | 3

It seems everything is default, which would not be displayed.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
repica.diff text/x-diff 11.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-27 13:15:52 psql \d+ and oid display
Previous Message Etsuro Fujita 2014-03-27 12:53:16 Re: inherit support for foreign tables