Re: Useless "Replica Identity: NOTHING" noise from psql \d

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date: 2014-03-26 15:53:32
Message-ID: 20140326155332.GI9567@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> On Wed, Mar 26, 2014 at 12:20:07PM -0300, Alvaro Herrera wrote:

> > Not opposed to this, but it seems a bit strange; REPLICA IDENTITY is a
> > property of the table, not of any individual index. I think we should
> > lose the token in the "Indexes" section.
>
> That is an interesting idea. It would mean that \d table would not show
> anything about replica identity, because right now it does:
>
> test=> \d test
> Table "public.test"
> Column | Type | Modifiers
> --------+---------+-----------
> x | integer | not null
> Indexes:
> "test_pkey" PRIMARY KEY, btree (x) REPLICA IDENTITY
>
> That seems logical.

Hmm. It seems to me that to make this more compact we could keep the
current token in the index line if it's INDEX, and not display the
Replica Identity: line at all; and if it's something other than index
and different from the default value, then print "Replica Identity" in
both \d and \d+.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-26 16:10:56 Re: Useless "Replica Identity: NOTHING" noise from psql \d
Previous Message Tom Lane 2014-03-26 15:37:28 Re: small regression adjustment