| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changeset Extraction v7.7 |
| Date: | 2014-02-26 20:10:56 |
| Message-ID: | 20140226201056.GH4759@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund escribió:
> On 2014-02-26 15:30:55 -0300, Alvaro Herrera wrote:
> > Andres Freund escribió:
> >
> > > I am wondering about the related situation of GetOldestXmin()
> > > callers. There's a fair bit of duplicated logic in the callers, before
> > > but especially after this patchset. What about adding 'Relation rel'
> > > parameter instead of `allDbs' and `systable'? That keeps the logic
> > > centralized and there's been a fair amount of talk about vacuum
> > > optimizations that could also use it.
> > > It's a bit sad that that requires including rel.h from procarray.h...
> >
> > relcache.h, not rel.h.
>
> RelationData is declared in rel.h, not relcache.h, no?
Sure, but with your patch AFAICT procarray.h header only needs Relation,
which is declared in relcache.h.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AlexK | 2014-02-26 20:12:30 | Adding a copying type for array elements |
| Previous Message | Stephen Frost | 2014-02-26 19:58:42 | Re: extension_control_path |