| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Changeset Extraction v7.7 |
| Date: | 2014-02-26 18:32:30 |
| Message-ID: | 20140226183230.GA6718@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-02-26 15:30:55 -0300, Alvaro Herrera wrote:
> Andres Freund escribió:
>
> > I am wondering about the related situation of GetOldestXmin()
> > callers. There's a fair bit of duplicated logic in the callers, before
> > but especially after this patchset. What about adding 'Relation rel'
> > parameter instead of `allDbs' and `systable'? That keeps the logic
> > centralized and there's been a fair amount of talk about vacuum
> > optimizations that could also use it.
> > It's a bit sad that that requires including rel.h from procarray.h...
>
> relcache.h, not rel.h.
RelationData is declared in rel.h, not relcache.h, no?
Alternatively we could just forward declare it in the header...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Leon Smith | 2014-02-26 18:47:04 | Simplified VALUES parameters |
| Previous Message | David Johnston | 2014-02-26 18:31:36 | Re: Function sugnature with default parameter |