Re: specifying repeatable read in PGOPTIONS

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: specifying repeatable read in PGOPTIONS
Date: 2014-02-09 17:10:22
Message-ID: 20140209171022.GA27393@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-02-09 12:00:02 -0500, Robert Haas wrote:
> On Fri, Feb 7, 2014 at 5:06 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > So I still think we should add read_committed, repeatable_read as aliases.
>
> Like Tom, I'm -1 on this. This is fixing the problem from the wrong end.

Why? We do have other options with aliases for option values and all
other enum option has taken care not to need spaces.

> But introducing an escaping convention seems more than prudent.

I've attached a patch implementing \ escapes one mail up... But I don't
really see that as prohibiting also adding sensible aliases.

It's just annoying that it's currently not possible to run to pgbenches
testing both without either restarting the user or ALTER ROLE/DATABASE.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeremy Harris 2014-02-09 17:11:30 Re: Minor performance improvement in transition to external sort
Previous Message Robert Haas 2014-02-09 17:00:02 Re: specifying repeatable read in PGOPTIONS