| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logging WAL when updating hintbit |
| Date: | 2013-12-20 14:06:16 |
| Message-ID: | 20131220140615.GU11006@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier escribió:
> On Fri, Dec 20, 2013 at 1:05 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > Sorry the patch which I attached has wrong indent on pg_controldata.
> > I have modified it and attached the new version patch.
> Now that you send this patch, I am just recalling some recent email
> from Tom arguing about avoiding to mix lower and upper-case characters
> for a GUC parameter name:
> http://www.postgresql.org/message-id/30569.1384917859@sss.pgh.pa.us
>
> To fullfill this requirement, could you replace walLogHints by
> wal_log_hints in your patch? Thoughts from others?
The issue is with the user-visible variables, not with internal
variables implementing them. I think the patch is sane. (Other than
the fact that it was posted as a patch-on-patch instead of
patch-on-master).
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2013-12-20 14:13:03 | [bug fix] psql \copy doesn't end if backend is killed |
| Previous Message | Alvaro Herrera | 2013-12-20 13:54:36 | Re: pgsql: Upgrade to Autoconf 2.69 |