| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Turning recovery.conf into GUCs |
| Date: | 2013-11-20 03:24:19 |
| Message-ID: | 30569.1384917859@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-11-19 22:09:48 +0900, Michael Paquier wrote:
>> On Tue, Nov 19, 2013 at 2:27 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> * Why did you change some of the recovery gucs to lowercase names, but
>>> left out XLogRestoreCommand?
>> This was part of the former patch, perhaps you are right and keeping
>> the names as close as possible to the old ones would make sense to
>> facilitate maintenance across versions.
> I think lowercase is slightly more consistent with the majority of the
> other GUCs, but if you change it you should change all the new GUC variables.
Please *don't* create any more mixed-case GUC names. The spelling of
TimeZone and the one or two other historical exceptions was a very
unfortunate thing; it's confused more people than it's helped.
Put in some underscores if you feel a need for word boundaries.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-11-20 03:32:20 | Re: Traffic jams in fn_extra |
| Previous Message | Tom Lane | 2013-11-20 03:21:47 | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |