| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: relscan_details.h |
| Date: | 2013-10-02 13:11:23 |
| Message-ID: | 20131002131123.GA21547@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 2, 2013 at 08:59:42AM -0400, Noah Misch wrote:
> On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote:
> > If we had not made massive cleanup changes years ago, our code would not
> > be as good as it is today. By avoiding cleanup to reduce the burden on
> > people who use our code, we are positioning our code on a slow decline
> > in clarity.
> >
> > What I don't want to do is get into a mode where every code cleanup has
> > to be verified that it isn't going to excessively burden outside code
> > users. Cleanup is hard enough, and adding another check to that process
> > makes cleanup even less likely.
>
> I don't disagree with that, but I would describe the proposal as a mild
> dirty-up for the sake of build performance, not a cleanup.
OK, good enough. Thanks for the feedback.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-10-02 13:29:28 | Re: Looking for information on our elephant |
| Previous Message | Sameer Thakur | 2013-10-02 13:10:51 | Re: pg_stat_statements: calls under-estimation propagation |