GetTransactionSnapshot() in enum.c

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: GetTransactionSnapshot() in enum.c
Date: 2013-08-19 12:29:38
Message-ID: 20130819122938.GB8558@alap2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

ISTM that we shouldn't use GetTransactionSnapshot() in enum.c but
GetLatestSnapshot() in <= 9.3 and NULL/GetCatalogSnapshot() > 9.3.

typecache.c's usage was converted to GetLatestSnapshot() but enum.c's
was not.

I don't seem to have full mental capacity right now, but I think the
current usage could cause problems with a range type index over a enum
column. Index predicates might also be problematic.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Charles Sheridan 2013-08-19 13:10:25 Automatic Index Creation for Column Types
Previous Message Albe Laurenz 2013-08-19 11:47:36 Re: LDAP: bugfix and deprecated OpenLDAP API