From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Kudos for Reviewers -- wrapping it up |
Date: | 2013-08-02 19:45:46 |
Message-ID: | 20130802194546.GD14543@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 12, 2013 at 12:18:15PM -0700, Joshua D. Drake wrote:
>
> On 07/12/2013 10:49 AM, Andrew Dunstan wrote:
> >
> >
> >On 07/12/2013 01:28 PM, Alvaro Herrera wrote:
> >>Josh Berkus wrote:
> >>
> >>>-- a couple of compromise proposals were made:
> >>>
> >>>a) that reviewers who do actual code modification of the patch get
> >>>credited on the feature, and those who just review it get credited at
> >>>the bottom of the release notes, or
> >>>
>
> >
> >I'd probably say "substantial" or "non-trivial", but otherwise +1
>
> Right cause if a reviewer ends up writing (or cleaning up) all the
> docs, I would say they deserve very close to equal credit. As an
> example.
I can do whatever we agree to in the release notes. The big question
is whether committers can properly document these people. I do think
the names are going to overwhelm the release note items and we will
_again_ remove some or all names.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2013-08-02 20:43:30 | Re: Kudos for Reviewers -- wrapping it up |
Previous Message | Tom Lane | 2013-08-02 19:23:29 | Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |