| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | 'Hitoshi Harada' <umi(dot)tanuki(at)gmail(dot)com>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Alexander Korotkov' <aekorotkov(at)gmail(dot)com>, 'pgsql-hackers' <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for removng unused targets |
| Date: | 2013-06-24 22:39:12 |
| Message-ID: | 20130624223912.GF4051@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Etsuro Fujita escribió:
> > From: Hitoshi Harada [mailto:umi(dot)tanuki(at)gmail(dot)com]
>
> > I tried several ways but I couldn't find big problems. Small typo:
> > s/rejunk/resjunk/
>
> Thank you for the review. Attached is an updated version of the patch.
Thanks. I gave this a look, and made it some trivial adjustments.
Attached is the edited version. I think this needs some more (succint)
code comments:
. why do we want to remove these entries
. why can't we do it in the DISTINCT case
. why don't we remove the cases we don't remove, within adjust_targetlist().
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| unused-targets-20130624.patch | text/x-diff | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2013-06-24 22:46:08 | Re: BUG #7493: Postmaster messages unreadable in a Windows console |
| Previous Message | Alexander Korotkov | 2013-06-24 22:24:37 | Re: GIN improvements part 3: ordering in index |