| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate |
| Date: | 2013-02-01 17:29:36 |
| Message-ID: | 20130201172936.GE6915@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2013-02-01 12:25:04 -0500, Bruce Momjian wrote:
> On Fri, Feb 1, 2013 at 01:50:02PM +0000, Álvaro Herrera wrote:
> > Fill tuple before HeapSatisfiesHOTAndKeyUpdate
> >
> > Failing to do this results in almost all updates to system catalogs
> > being non-HOT updates, because the OID column would differ (not having
> > been set for the new tuple), which is an indexed column.
> >
> > While at it, make sure to set the tableoid early in both old and new
> > tuples as well. This isn't of much consequence, since that column is
> > seldom (never?) indexed.
> >
> > Report and patch from Andres Freund.
>
> Was this a new bug in 9.3?
Yes, it got introduced in the fklocks patch. The 'tableoid' part is
present before that, but I can't see a usecase in indexing that column,
so I think not backpatching it is ok.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-02-01 19:46:52 | Re: Re: [COMMITTERS] pgsql: Tolerate timeline switches while "pg_basebackup -X fetch" is run |
| Previous Message | Bruce Momjian | 2013-02-01 17:25:04 | Re: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate |