Re: Bugs in CREATE/DROP INDEX CONCURRENTLY

On 2012-11-28 17:42:18 -0500, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > One minor thing I haven't noticed earlier: Perhaps we should also skip
> > over invalid indexes in transformTableLikeClause's
> > CREATE_TABLE_LIKE_INDEXES case?
>
> I left that as-is intentionally: the fact that an index isn't valid
> doesn't prevent us from cloning it. A relevant data point is that
> pg_dump doesn't care whether indexes are valid or not --- it'll dump
> their definitions anyway.
>
> I agree it's a judgment call, though. Anybody want to argue for the
> other position?

Hm. Seems odd to include indexes that are being dropped concurrently at
that moment. But then, we can't really detect that situation and as you
say its consistent with pg_dump...

Hm.

Greetings,

Andres Freund