Re: TRUE/FALSE vs true/false

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: TRUE/FALSE vs true/false
Date: 2012-08-14 19:24:53
Message-ID: 20120814192453.GC11913@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 4, 2011 at 09:00:11PM +0300, Peter Eisentraut wrote:
> On tor, 2011-08-04 at 14:44 +0200, Boszormenyi Zoltan wrote:
> > 2011-08-04 14:32 keltezéssel, Robert Haas írta:
> > > 2011/8/4 Boszormenyi Zoltan <zb(at)cybertec(dot)at>:
> > >> Shouldn't these get fixed to be consistent?
> > > I believe I already did. See commit 85b436f7b1f06a6ffa8d2f29b03d6e440de18784.
> >
> > I meant a mass "sed -e 's/TRUE/true/g' -e 's/FALSE/false/g'" run
> > so all the ~200 occurrences of both "TRUE" and "FALSE" get
> > converted so the whole source tree is consistent.
>
> I would be in favor of that.

I have implemented this with the patch at:

http://momjian.us/expire/true_diff.txt

I did not modify the Win32 code which traditionally uses uppercase for
TRUE/FALSE.

It would be applied only to HEAD.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2012-08-14 20:02:33 Re: SIGFPE handler is naive
Previous Message Heikki Linnakangas 2012-08-14 19:23:02 Re: default_isolation_level='serializable' crashes on Windows