Re: Command Triggers

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Command Triggers
Date: 2011-12-01 19:18:41
Message-ID: 201112012018.41522.andres@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, December 01, 2011 07:21:25 PM Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On Tuesday, November 08, 2011 06:47:13 PM Dimitri Fontaine wrote:
> >> exception to that rule would be SELECT INTO and CREATE TABLE AS SELECT,
> >> and my proposal would be to add specific call sites to the functions
> >> I've provided in the attached patch rather than try to contort them into
> >> being a good citizen as a utility command.
> >
> > I would very much prefer to make them utility commands and rip out the
> > executor support for that.
> > Is there something making that especially hard that I overlooked? The
> > infrastructure for doing so seems to be there.
>
> Well, I think the main problem is going to be shunting the query down
> the right parsing track (SELECT versus utility-statement) early enough.
> Making this work cleanly would be a bigger deal than I think you're
> thinking.
Yes. I forgot how ugly SELECT INTO is...

> But yeah, it would be nicer if the executor didn't have to worry about
> this. +1 if you're willing to take on the work.
I won't promise anything but I will play around with the grammar and see if I
find a nice enough way.

Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-12-01 20:32:34 TupleDescInitEntry failing to initialize varlen members
Previous Message Jim Buttafuoco 2011-12-01 19:09:04 Re: Postgresql 9.1 replication failing