TupleDescInitEntry failing to initialize varlen members

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: TupleDescInitEntry failing to initialize varlen members
Date: 2011-12-01 20:32:34
Message-ID: 1322771352-sup-2814@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi,

I just noticed in gdb that TupleDescInitEntry does not initialize
attacl, attoptions, attfdwoptions. This is probably not very serious
(otherwise we'd have bugs about it), but it is noticeable in tupdescs
constructed by the executor, at least ExecTypeFromTL:

(gdb) print *tupDesc->attrs[2]
$6 = {attrelid = 0, attname = {data = "c", '\000' <repeats 62 times>}, atttypid = 1114,
attstattarget = -1, attlen = 8, attnum = 3, attphysnum = 3, attlognum = 3, attndims = 0,
attcacheoff = -1, atttypmod = -1, attbyval = 1 '\001', attstorage = 112 'p', attalign = 100 'd',
attnotnull = 0 '\000', atthasdef = 0 '\000', attisdropped = 0 '\000', attislocal = 1 '\001',
attinhcount = 0, attcollation = 0, attacl = {2139062142}, attoptions = {{
vl_len_ = "\177\177\177\177", vl_dat = "\177"}}, attfdwoptions = {{
vl_len_ = "\177\177\177\177", vl_dat = "\177"}}}

Does anybody think this is worth fixing?

--
Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2011-12-01 20:57:40 Re: Command Triggers
Previous Message Andres Freund 2011-12-01 19:18:41 Re: Command Triggers