Re: pgsql: Make pg_dumpall build with the right object files under MSVC.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make pg_dumpall build with the right object files under MSVC.
Date: 2011-11-28 16:33:14
Message-ID: 201111281633.pASGXEY29658@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan wrote:
> Make pg_dumpall build with the right object files under MSVC.
>
> This fixes a longstanding but up to now benign bug in the way pg_dumpall
> was built. The bug was exposed by recent code adjustments. The Makefile
> does not use $(OBJS) to build pg_dumpall, so this fix removes their source
> files from the pg_dumpall object and adds in the one source file it
> consequently needs.

In summary, for those watching, pg_dump and pg_restore used to share
OBJS, and with my new patch, dumpmem.c is now shared by those and
pg_dumpall. Seems the MSVC code previously could not handle that case,
which is fixed by this patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2011-11-28 17:40:24 Re: pgsql: Make pg_dumpall build with the right object files under MSVC.
Previous Message Andrew Dunstan 2011-11-28 12:55:00 pgsql: Backpatch "Use the preferred version of xsubpp."

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2011-11-28 17:00:45 Re: Prep object creation hooks, and related sepgsql updates
Previous Message Tom Lane 2011-11-28 15:55:02 Re: Patch: add timing of buffer I/O requests