Re: .psqlrc version dependence (was Re: about EDITOR_LINENUMBER_SWITCH)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: .psqlrc version dependence (was Re: about EDITOR_LINENUMBER_SWITCH)
Date: 2011-10-15 16:02:54
Message-ID: 201110151602.p9FG2s517424@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Contrary to what the subject suggests, I think the main reason people
> > wanted this feature was to be able to set the linestyle to unicode
> > without getting a warning from older releases about unknown linestyle or
> > something. But in a few years, they'll have to
> > maintain .psqlrc-9.2, .psqlrc-9.3, .psqlrc-9.4, etc. That doesn't sound
> > like a useful long-term solution either.
>
> Well, "in a few years" they won't need that conditionality any more at
> all, so I'm not sure I believe the above argument. The problem seems
> inherently self-limiting.
>
> What struck me while looking at the patch is that it is conditional
> based on *psql's* version. Not the version of the server you're
> connected to. I'm not too sure what use-cases people have for version
> dependence here, but I'd think that the server version would enter into
> it sometimes.

The assumption is that the .psqlrc is controlling psql behavior. Not
sure what setting would be changed based on server version, maybe psql
variables.

I have updated the docs to indicate it is the psql version.

> (Of course, for server version to be used usefully, you'd need to
> re-execute the rc file during \c, something we don't do now.)

Yep, yuck.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2011-10-15 16:45:45 Re: Call stacks and RAISE INFO
Previous Message Tom Lane 2011-10-15 15:32:16 .psqlrc version dependence (was Re: about EDITOR_LINENUMBER_SWITCH)