Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Michael Meskes <michael(at)fam-meskes(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname
Date: 2011-02-17 17:51:30
Message-ID: 201102171751.p1HHpUi11691@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Boszormenyi Zoltan wrote:
> Kevin Grittner ?rta:
> > Michael Meskes <michael(at)fam-meskes(dot)de> wrote:
> >
> >> All prior ECPG versions were fine because dynamic cursor names
> >> were only added in 9.0. Apparently only this one place was
> >> missed. So this is a bug in the new feature, however not such a
> >> major one that it warrants the complete removal IMO. I'd prefer to
> >> fix this in 9.0.1.
> >>
>
> As we are so late in the beta phase, we can live with that, hopefully
> you will find time by then to review the patch which is actually not
> that complex, only a bit large. The part of ECPGdo() that deals with
> auto-preparing statements is moved closer to calling ecpg_execute(),
> after the varargs are converted to stmt->inlist and ->outlist.
>
> >> Hope this cleans it up a bit.
> >>
> >
> > Thanks. I think I get it now.
> >
> > To restate from another angle, to confirm my understanding: UPDATE
> > WHERE CURRENT OF is working for cursors with the name hard-coded in
> > the embedded statement, which is the only way cursor names were
> > allowed to be specified prior to 9.0; 9.0 implements dynamic cursor
> > names, allowing you to use a variable for the cursor name; but this
> > one use of a cursor name isn't allowing a variable yet. Do I have
> > it right? (If so, I now see why it would be considered a bug.)
> >
>
> Yes, you understand it correctly.

Did this ever get applied? If so, I can't find it.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-02-17 17:54:45 Re: Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.
Previous Message Bruce Momjian 2011-02-17 17:37:31 Re: patch (for 9.1) string functions ( correct patch attached )