Re: Fw: patch for pg_ctl.c to add windows service start-type

From: David Fetter <david(at)fetter(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Quan Zongliang <quanzongliang(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fw: patch for pg_ctl.c to add windows service start-type
Date: 2010-08-19 20:51:08
Message-ID: 20100819205108.GB24472@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 19, 2010 at 04:48:53PM -0400, Alvaro Herrera wrote:
> Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010:
> > On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote:
> > > Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010:
> > >
> > > > + <varlistentry>
> > > > + <term><option>-S <replaceable class="parameter"></replaceable></option></term>
> > >
> > > You omitted the start-type inside the <replaceable> tag. Also,
> > > the "a" and "d" values seem to be accepted but not documented.
> >
> > D'oh! Changed patch enclosed. Now in context format :)
>
> Thanks.
>
> Another thing -- why is there an enum at all? Seems it'd be simpler
> to assign the right value to the variable in the getopt() code to
> start with.

That's a question for the patch author. I was just cleaning up the
docs :)

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-08-19 20:53:06 Re: small typed-table bug in gram.y
Previous Message Robert Haas 2010-08-19 20:49:41 small typed-table bug in gram.y