| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Quan Zongliang <quanzongliang(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fw: patch for pg_ctl.c to add windows service start-type |
| Date: | 2010-08-19 20:48:53 |
| Message-ID: | 1282250821-sup-8424@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010:
> On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote:
> > Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010:
> >
> > > + <varlistentry>
> > > + <term><option>-S <replaceable class="parameter"></replaceable></option></term>
> >
> > You omitted the start-type inside the <replaceable> tag. Also, the "a"
> > and "d" values seem to be accepted but not documented.
>
> D'oh! Changed patch enclosed. Now in context format :)
Thanks.
Another thing -- why is there an enum at all? Seems it'd be
simpler to assign the right value to the variable in the getopt() code
to start with.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-08-19 20:49:41 | small typed-table bug in gram.y |
| Previous Message | David Fetter | 2010-08-19 20:40:18 | Re: Fw: patch for pg_ctl.c to add windows service start-type |