Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Hartmut Goebel <h(dot)goebel(at)goebel-consult(dot)de>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Date: 2010-06-10 12:44:50
Message-ID: 20100610124450.GY21875@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Bruce,

* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> Robert Haas wrote:
> > > In a way, the fact that the restore fails can be seen as a feature ---
> > > they get the error before the go live on 8.4. ?(Yeah, I am serious.)
> >
> > Eeh, I've had this happen to me on earlier releases, and it didn't
> > feel like a feature to me. YMMV, of course.
>
> Would you have preferred later application failure?

If it's an option w/ a default of "off", then chances are the admin will
get the failure you're talking about, realize there's an issue, but then
have a way to actually *fix* the restore without having to hack up
multi-gigabyte files using vi. If you'd like, you're welcome to
consider the default of "off" as a feature.

+1 from me for adding the option.

Thanks,

Stephen

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Hartmut Goebel 2010-06-10 12:51:24 Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Previous Message Kevin Grittner 2010-06-10 11:46:24 Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading