| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ECPGset_var |
| Date: | 2010-01-26 18:32:45 |
| Message-ID: | 20100126183245.GG3380@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Boszormenyi Zoltan wrote:
> Thanks for analyzing it, patch is attached. I downloaded
> and installed ICC, so I could reproduce the difference.
Why not have a single function that does both things in a single call?
It doesn't look like there's any place that calls the function with only
one value for "insert" ...
I happened to notice this misleading comment:
char temp[20]; /* this should be sufficient unless you have 8 byte integers */
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2010-01-26 18:33:20 | Re: Dividing progress/debug information in pg_standby, and stat before copy |
| Previous Message | David Fetter | 2010-01-26 18:20:26 | Re: [COMMITTERS] pgsql: Remove tabs in SGML. |