pgsql: Fix (some of the) breakage introduced into query-cancel

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix (some of the) breakage introduced into query-cancel
Date: 2010-01-07 16:29:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
Fix (some of the) breakage introduced into query-cancel processing by HS.

It is absolutely not okay to throw an ereport(ERROR) in any random place in
the code just because DoingCommandRead is set; interrupting, say, OpenSSL
in the midst of its activities is guaranteed to result in heartache.

Instead of that, undo the original optimizations that threw away
QueryCancelPending anytime we were starting or finishing a command read, and
instead discard the cancel request within ProcessInterrupts if we find that
there is no HS reason for forcing a cancel and we are DoingCommandRead.

In passing, may I once again condemn the practice of changing the code
and not fixing the adjacent comment that you just turned into a lie?

Modified Files:
postgres.c (r1.580 -> r1.581)


Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-01-07 19:53:11 pgsql: Make bit/varbit substring() treat any negative length as meaning
Previous Message Bruce Momjian 2010-01-07 14:35:44 pgsql: Use -Z for vacuumdb --analyze-only, rather than -o.