Re: pgsql: Fix (some of the) breakage introduced into query-cancel

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Date: 2010-01-08 02:11:26
Message-ID: 1262916686.19367.96522.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote:

> Instead of that, undo the original optimizations that threw away
> QueryCancelPending anytime we were starting or finishing a command
> read, and instead discard the cancel request within ProcessInterrupts
> if we find that there is no HS reason for forcing a cancel and we are
> DoingCommandRead.

Is there a reason why we are calling DisableNotifyInterrupt() and
DisableCatchupInterrupt() before we call ProcessInterrupts() and again
within it?

--
Simon Riggs www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Fxjr 2010-01-08 02:32:58 npgsql - Npgsql2: [#1010746] NpgsqlDate.AddMonths(m):
Previous Message Takahiro Itagaki 2010-01-08 00:48:56 pgsql: pgBufferUsage needs PGDLLIMPORT for pg_stat_statements on