Re: CREATE LIKE INCLUDING COMMENTS and STORAGES

From: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: CREATE LIKE INCLUDING COMMENTS and STORAGES
Date: 2009-09-28 10:08:43
Message-ID: 20090928190642.9291.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I removed hunks by sql_help.c and fix a typo in documentation.
An updated patch attached.

Brendan Jurd <direvus(at)gmail(dot)com> wrote:

> With the sql_help.c changes removed, the patch applied fine and
> testing went well.
>
> I noticed only the following in the new documentation in CREATE TABLE:
> - <literal>INCLUDING DEFAULTS INCLUDING CONSTRAINTS INCLUDING INDEXES INCLUDING STORAGES INCLUDING COMMENTS</literal>.
> + <literal>INCLUDING DEFAULTS INCLUDING CONSTRAINTS INCLUDING INDEXES INCLUDING STORAGE INCLUDING COMMENTS</literal>.
>
> Aside from the bogus hunks in the patch, and this one typo, the patch
> looks to be in excellent shape.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
create-including_20090928a.patch application/octet-stream 35.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-09-28 10:11:50 Re: Rejecting weak passwords
Previous Message Albe Laurenz 2009-09-28 09:54:17 Rejecting weak passwords