Re: libpq WSACleanup is not needed

Andrew Dunstan wrote:
>
>
> Andrew Chernow wrote:
> > Andrew Chernow wrote:
> >> Bruce Momjian wrote:
> >>>
> >>> Ah, OK, so it does its own cleanup on last close, great. I agree a
> >>> connection option for this would be good.
> >>>
> >>
> >> What would the option be? "wsainit = [enable | disable]"? Maybe it
> >> should allow setting the version to load: "wsa_version = 2.0". Maybe
> >> the two should be combined: "wsa_version = [default | disable | 2.0]".
> >>
> >
> > I will say, the cleanest solution is still an optional init()/uninit()
> > for libpq. Has this been ruled out? IMHO, the next best solution is
> > a connection option.
>
> What happened to the idea of counting connections? That seemed a
> relatively clean way to go, I thought, although I haven't followed the
> discussion very closely.

I was told WSACleanup does connection counting internally (only the
final close has a performance impact) so there is no need to do the
counting like we do for SSL callbacks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +