Re: Interval literal rounding bug(?) and patch.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Ron Mayer <rm_pg(at)cheapcomplexdevices(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Interval literal rounding bug(?) and patch.
Date: 2008-09-24 19:46:54
Message-ID: 200809241946.m8OJksv28020@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ron Mayer wrote:
> I think it's a bug that these 3 different ways of writing 0.7 seconds
> produce different results from each other on HEAD.
>
> head=# select interval '0:0:0.7', interval '@ 0.70 secs', interval '0.7 seconds';
> interval | interval | interval
> -------------+-----------------+-----------------
> 00:00:00.70 | 00:00:00.699999 | 00:00:00.699999
> (1 row)
>
> The attached patch will make all of those output "00:00:00.70" which.
>
> Postgres 8.3 tended to output the "00:00:00.70" like this patch, I believe
> because it didn't default to HAVE_INT64_TIMESTAMP like HEAD is. The patch
> seems to pass the existing regression tests.
>
> Does this seem reasonable?

Yes, very nice; patch applied. Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-09-24 20:14:33 Re: FSM, now without WAL-logging
Previous Message Tom Lane 2008-09-24 19:46:22 Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)