| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Solve a problem of LC_TIME of windows. |
| Date: | 2008-09-24 14:15:19 |
| Message-ID: | 20080924141519.GA10480@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander wrote:
> Also, the patch needs error checking. strftime() can fail, and the
> multibyte conversion functions can certainly fail. That will need to be
> added.
What about this line?
#define STRLEN_MAX 255
Are we really sure the strftime format cannot be longer than that?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2008-09-24 14:28:54 | Re: Initial prefetch performance testing |
| Previous Message | KaiGai Kohei | 2008-09-24 14:13:18 | Re: Updates of SE-PostgreSQL 8.4devel patches |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Saito | 2008-09-24 14:55:10 | Re: Solve a problem of LC_TIME of windows. |
| Previous Message | Simon Riggs | 2008-09-24 12:48:45 | Re: [PATCHES] Subtransaction commits and Hot Standby |