Re: pg_dump vs data-only dumps vs --disable-triggers

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: pg_dump vs data-only dumps vs --disable-triggers
Date: 2008-07-25 00:46:30
Message-ID: 20080725004630.GA16005@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Simon's patch to split up --schema-only into two switches has broken
> this logic, but I'm inclined to just rip it out rather than trying
> to fix it. If the user says --disable-triggers, he should get
> trigger disable commands around the data part of the dump, no matter
> what he said or didn't say about schema dumping.

Agreed entirely. I was suspicious of that bit of code but, honestly,
wasn't quite sure what the original intent had been. Sorry I havn't
finished my review of his latest, he went and changed all the macro
names. ;) If you're taking care of it then I won't spend any further
time on it.. I'm pretty comfortable with it now, honestly, provided the
renaming didn't change anything and my last set of comments were
included.

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-07-25 01:00:10 Re: Additional psql requirements
Previous Message Tatsuo Ishii 2008-07-25 00:26:52 Re: [PATCHES] WITH RECUSIVE patches 0723