| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Xiao Meng <mx(dot)cogito(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Kenneth Marshall <ktm(at)rice(dot)edu>, "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com> |
| Subject: | Re: [PATCH]-hash index improving |
| Date: | 2008-07-17 16:42:39 |
| Message-ID: | 20080717164239.GH3934@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Xiao Meng escribió:
> The patch store hash code only in the index tuple.
> It based on Neil Conway's patch with an old version of PostgreSQL.
> It passes the regression test but I didn't test the performance yet.
> Anyone interested can make a performance test;-)
> You can undefine the macro HASHVALUE_ONLY in hash.h to get the
> original implementation.
I think having the HASHVALUE_ONLY define is not a good idea -- it just
makes the patch harder to read. I suggest just removing the old code
and putting the new code in place. (That's why we have revision
control.)
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2008-07-17 17:07:31 | Re: PATCH: CITEXT 2.0 v4 |
| Previous Message | Decibel! | 2008-07-17 16:19:36 | Re: [HACKERS] postmaster.pid not visible |