Skip site navigation (1) Skip section navigation (2)

Re: Improve shutdown during online backup, take 4

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Improve shutdown during online backup, take 4
Date: 2008-04-23 13:45:40
Message-ID: 20080423154540.64dd7862@mha-laptop (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-patches
Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > + 	if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> > 
> > (there's a number of similar places)
> 
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Applied with some minor changes to the error messages to make them
closer to our guidelines. (With my track record, it's not entirely
unlikely that someone will fix them further though :-P)

//Magnus

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-04-23 13:57:29
Subject: Re: temporal version of generate_series()
Previous:From: Alvaro HerreraDate: 2008-04-23 13:43:44
Subject: Re: Snapshot management, final

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group