Re: Snapshot management, final

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Snapshot management, final
Date: 2008-04-23 13:43:44
Message-ID: 20080423134344.GG4768@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-patches

Simon Riggs wrote:

> Forgive me for being dense, but what is there to stop you using a
> CopySnapshot in TopMemoryContext? If you did, there would be no way to
> free it, nor would we notice it had been done, AFAICS. Not anything I'm
> thinking about doing, though.

Well, TopMemoryContext is no good because we want to free snapshots in a
fell swoop at transaction abort. TopTransactionContext would be OK, as
I just said in the parallel subthread.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2008-04-23 13:45:40 Re: Improve shutdown during online backup, take 4
Previous Message Simon Riggs 2008-04-23 13:25:15 Re: Snapshot management, final