pgsql: Fix a couple of oversights associated with the "physical tlist"

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a couple of oversights associated with the "physical tlist"
Date: 2008-04-17 21:22:14
Message-ID: 20080417212214.C7C097559CC@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Fix a couple of oversights associated with the "physical tlist" optimization:
we had several code paths where a physical tlist could be used for the input
to a Sort node, which is a dumb idea because any unneeded table columns will
increase the volume of data the sort has to push around.

(Unfortunately the easy-looking fix of calling disuse_physical_tlist during
make_sort_xxx doesn't work because in most cases we're already committed to
the current input tlist --- it's been marked with sort column numbers, or
we've built grouping column numbers using it, etc. The tlist has to be
selected properly at the calling level before we start constructing sort-col
information. This is easy enough to do, we were just failing to take the
point into consideration.)

Back-patch to 8.3. I believe the problem probably exists clear back to 7.4
when the physical tlist optimization was added, but I'm afraid to back-patch
further than 8.3 without a great deal more study than I want to put into it.
The code in this area has drifted a lot over time. The real-world importance
of these code paths is uncertain anyway --- I think in many cases we'd
probably prefer hash-based methods.

Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
createplan.c (r1.239 -> r1.240)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.239&r2=1.240)
planner.c (r1.231 -> r1.232)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planner.c?r1=1.231&r2=1.232)
pgsql/src/include/optimizer:
planmain.h (r1.106 -> r1.107)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/planmain.h?r1=1.106&r2=1.107)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-04-17 21:22:23 pgsql: Fix a couple of oversights associated with the "physical tlist"
Previous Message Bruce Momjian 2008-04-17 20:58:10 Re: pg_terminate_backend() issues

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2008-04-17 23:23:19 Re: Plan targetlists in EXPLAIN output
Previous Message Bruce Momjian 2008-04-17 21:04:21 Re: Proposed patch - psql wraps at window width