Re: pg_terminate_backend() issues

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_terminate_backend() issues
Date: 2008-04-17 20:58:10
Message-ID: 200804172058.m3HKwA421845@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> The closest thing I can think of to an automated test is to run repeated
> >> sets of the parallel regression tests, and each time SIGTERM a randomly
> >> chosen backend at a randomly chosen time. Then see if anything "funny"
>
> > Yep, that was my plan, plus running the parallel regression tests you
> > get the possibility of >2 backends.
>
> I was intentionally suggesting only one kill per test cycle. Multiple
> kills will probably create an O(N^2) explosion in the set of possible
> downstream-failure deltas. I doubt you'd really get any improvement
> in testing coverage to justify the much larger amount of hand validation
> needed.
>
> It also strikes me that you could make some simple alterations to the
> regression tests to reduce the set of observable downstream deltas.
> For example, anyplace where a test loads a table with successive INSERTs
> and that table is used by later tests, wrap the INSERT sequence with
> BEGIN/END. Then there is only one possible downstream delta (empty
> table) and not N different possibilities for an N-row table.

I have added pg_terminate_backend() to use SIGTERM and will start
running tests as discussed with Tom. I will post my scripts too.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-04-17 21:22:14 pgsql: Fix a couple of oversights associated with the "physical tlist"
Previous Message Bruce Momjian 2008-04-17 20:57:07 pgsql: TODO Done: > * -Allow administrators to safely terminate

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-17 21:03:20 Re: Proposed patch - psql wraps at window width
Previous Message Bruce Momjian 2008-04-17 20:55:12 Re: Proposed patch - psql wraps at window width