| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Bryce Nesbitt <bryce2(at)obviously(dot)com>, heikki(at)enterprisedb(dot)com |
| Subject: | Re: Proposed patch - psql wraps at window width |
| Date: | 2008-04-17 13:09:23 |
| Message-ID: | 200804171509.25472.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> I checked the use of COLUMNS and it seems bash updates the environment
> variable when a window is resized. I added ioctl(TIOCGWINSZ) if COLUMNS
> isn't set. We already had a call in print.c for detecting the
> number of rows on the screen to determine if the pager should
> be used. Seems COLUMNS should take precedence over ioctl(), right?
Considering that the code to determine the row count is undisputed so far, the
column count detection should work the same. That is, we might not need to
look at COLUMNS at all. Unless there is a use case for overriding the column
count (instead of just turning off the wrapping).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-04-17 13:14:13 | Re: Re: [COMMITTERS] pgsql: Repair two places whereSIGTERM exit couldleave shared memory |
| Previous Message | Alvaro Herrera | 2008-04-17 13:05:43 | Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2008-04-17 13:18:54 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
| Previous Message | Alvaro Herrera | 2008-04-17 12:34:52 | Re: Proposed patch - psql wraps at window width |