Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory
Date: 2008-04-17 13:05:43
Message-ID: 20080417130543.GF3846@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Heikki Linnakangas wrote:
> Alvaro Herrera wrote:
>> Tom Lane wrote:
>>
>>> Also use this method
>>> for createdb cleanup --- that wasn't a shared-memory-corruption problem,
>>> but SIGTERM abort of createdb could leave orphaned files lying around.
>>
>> I wonder if we could use this mechanism for cleaning up in case of
>> failed CLUSTER, REINDEX or the like. I think these can leave dangling
>> files around.
>
> They do clean up on abort or SIGTERM.

Ah, we're OK then.

> If you experience a sudden power loss, or kill -9 while CLUSTER or
> REINDEX is running, they will leave behind dangling files, but that's
> a different problem.

Sure, no surprises there.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-04-17 13:14:13 Re: Re: [COMMITTERS] pgsql: Repair two places whereSIGTERM exit couldleave shared memory
Previous Message Heikki Linnakangas 2008-04-17 13:03:18 Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-04-17 13:09:23 Re: Proposed patch - psql wraps at window width
Previous Message Heikki Linnakangas 2008-04-17 13:03:18 Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory