Re: MSVC build broken with perl 5.10

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: MSVC build broken with perl 5.10
Date: 2008-04-10 14:12:56
Message-ID: 20080410161256.222d01d7@mha-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> > I just tried the MSVC build on a system with ActiveState Perl 5.10,
> > and it doesn't work. Some quick debugging before I downgraded to
> > 5.8 showed that this regexp in Project.pm line 262:
> > my $replace_re =
> > qr{^([^:\n\$]+\.c)\s*:\s*(?:%\s*: )?\$(\([^\)]+\))\/(.*)\/[^\/]+$};
> >
> > matches things properly using Perl 5.8 in for example
> > src/bin/initdb/Makefile (matches a total of around 10 Makefiles),
> > but in 5.10 it simply does not match anything...
> >
> > Any perl guru out there who can comment on why? ;-)
> >
> >
>
> Perhaps you would like to comment it using the x format, so that it
> doesn't just look like white noise.

That would be a good idea, no? ;-) I have no idea what you mean with
"using the x format", though, but I agree in general that the
white-noise format is not a good idea...

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-10 14:15:29 Re: Commit fest queue
Previous Message Joshua D. Drake 2008-04-10 14:10:20 Re: Commit fest queue

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-10 14:22:44 Re: Concurrent psql API
Previous Message Andrew Chernow 2008-04-10 13:45:46 Re: [PATCHES] libpq type system 0.9a