Re: BUG #3681: fillers are NULL in pgbench

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: BUG #3681: fillers are NULL in pgbench
Date: 2008-03-12 13:11:48
Message-ID: 200803121311.m2CDBmV15977@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches


This was applied by Tom. Thanks.

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
>
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> > > All of filler fields in branches, tellers and history is NULL. It is
> > > probabbly a mistake because there are fields of char(22-88) in the table
> > > definitions.
> > > TPC-B requires at least 100 bytes per row for all tables used in it.
> >
> > I'm not in favor of changing this. pgbench has never pretended to be
> > "really" TPC-B, nor has anyone ever tried to compare its numbers against
> > other TPC-B numbers. On the other hand, people *do* compare pgbench
> > numbers to itself over time, and if we make a change like this it will
> > break comparability of the results.
>
> Ok, I feel it reasonable.
> The attached is a patch to mention it in the source code.
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2008-03-12 13:18:41 Re: BUG #4027: backslash escaping not disabled in plpgsql
Previous Message Magnus Hagander 2008-03-12 08:25:55 Re: BUG #4025: wsock32.dll not found

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-03-12 13:12:33 Re: Proposed patch for LISTEN/NOTIFY race condition
Previous Message Martijn van Oosterhout 2008-03-12 08:16:27 Re: [NOVICE] encoding problems