Re: type money causes unrestorable dump

From: "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: type money causes unrestorable dump
Date: 2007-10-09 16:33:15
Message-ID: 20071009123315.5fb283c1.darcy@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

[Note: Cc list trimmed as everyone is probably on the list anyway]

On Tue, 9 Oct 2007 09:02:09 -0700
"Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:
> However, keep in mind that I really don't care if Money is deprecated
> or not. I do care that the docs say it is, and it may not be. :)

Understood. Personally I would like to see that comment dropped but it
isn't my decision. I did fix the biggest complaints in the recent
change to 64 bit storage so perhaps someone can see their way clear to
dropping that comment. Here is a suggested change.

Index: datatype.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/datatype.sgml,v
retrieving revision 1.209
diff -u -p -u -r1.209 datatype.sgml
--- datatype.sgml 31 Aug 2007 04:52:29 -0000 1.209
+++ datatype.sgml 9 Oct 2007 16:30:13 -0000
@@ -828,14 +828,6 @@ ALTER SEQUENCE <replaceable class="param
<sect1 id="datatype-money">
<title>Monetary Types</title>

- <note>
- <para>
- The <type>money</type> type is deprecated. Use
- <type>numeric</type> or <type>decimal</type> instead, in
- combination with the <function>to_char</function> function.
- </para>
- </note>
-
<para>
The <type>money</type> type stores a currency amount with a fixed
fractional precision; see <xref
@@ -846,6 +838,15 @@ ALTER SEQUENCE <replaceable class="param
Output is generally in the latter form but depends on the locale.
</para>

+ <para>
+ Due to locale changes this type may have problems with dump and
+ restore and care should be taken. Also, I/O is slower than using
+ NUMERIC or DECIMAL but internal calculations such as SUM will be
+ faster due to its internal storage format. Be sure to weigh all
+ these considerations as well as convenience when choosing between
+ this type and others.
+ </para>
+
<table id="datatype-money-table">
<title>Monetary Types</title>
<tgroup cols="4">

--
D'Arcy J.M. Cain <darcy(at)druid(dot)net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 425 1212 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2007-10-09 16:40:23 Re: mal advice in FAQ 4.1.
Previous Message Peter Eisentraut 2007-10-09 16:16:18 Re: Uninformative messages from pg_ctl