Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Neil Conway <neilc(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.
Date: 2007-04-12 15:45:23
Message-ID: 20070412154523.GD15947@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Neil Conway wrote:
> Log Message:
> -----------
> RESET SESSION, plus related new DDL commands.

This phrase is missing a verb:

The default value is defined as the value that the parameter would
have had, if no <command>SET</> ever been issued for it in the
current session.

/pgsql/doc/src/sgml/ref/reset.sgml

I find this markup strange:

<synopsis>
SET SESSION AUTHORIZATION DEFAULT;
RESET ALL;
DEALLOCATE ALL;
CLOSE ALL;
UNLISTEN *;
RESET PLANS;
RESET TEMP;
</synopsis>

shouldn't it be using <programlisting> ?

In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
instead of the SysCache lookup?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Hinoue 2007-04-12 16:16:41 psqlodbc - psqlodbc: Use '(0,0)' instead of '(,)' as a dummy CTID.
Previous Message Tom Lane 2007-04-12 15:04:47 pgsql: Cancel pending fsync requests during WAL replay of DROP DATABASE,

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-04-12 15:49:57 Re: Autovacuum PGPROCs in ProcGlobal? (was Re: autovacuum multiworkers)
Previous Message Tom Lane 2007-04-12 15:42:20 Re: [HACKERS] Fix mdsync never-ending loop problem