| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands. |
| Date: | 2007-04-12 22:38:54 |
| Message-ID: | 1176417534.6382.7.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, 2007-04-12 at 11:45 -0400, Alvaro Herrera wrote:
> This phrase is missing a verb:
> [...]
> I find this markup strange:
> [...]
> In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
> instead of the SysCache lookup?
All fair points: I've applied the attached patch. Thanks for the review.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| ddl_fixes-2.patch | text/x-patch | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2007-04-12 22:39:21 | pgsql: Minor fixes for the EXPLAIN reference page. |
| Previous Message | Neil Conway | 2007-04-12 22:34:45 | pgsql: Fixes for RESET SESSION patch, per Alvaro. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2007-04-12 22:41:03 | Re: Idle idea for a feature |
| Previous Message | Steve | 2007-04-12 22:24:48 | Re: Strangely Variable Query Performance |