Re: Packed Varlena Update (v21)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Packed Varlena Update (v21)
Date: 2007-04-10 01:33:26
Message-ID: 200704100133.l3A1XQ419362@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Added to TODO:

o Allow single-byte header storage for arrays

---------------------------------------------------------------------------

Tom Lane wrote:
> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> > "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> >> Forgot to mention: one of the revisions was to not add the "sizes.sql"
> >> test, because the output was platform-dependent and is likely to get
> >> more so if any ability to change the toast thresholds gets put in.
> >> Can we improve that test to not expose any platform-dependent numbers?
>
> > I had imagined that we would have two versions of output files. Other than
> > 32-bit versus 64-bit what other platform-dependent variations enter into it?
>
> If there'd be only two then I'd be all right with it, but I'm worried
> that making TOAST thresholds configurable would result in lots more
> possible outputs than that.
>
> BTW, another area that should be kept on the TODO list is to see whether
> it makes sense to support 1-byte-header format for array elements.
> I looked at that briefly while reviewing the patch but decided it was a
> large additional chunk of work and not on the critical path.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2007-04-10 02:02:00 Re: [PATCHES] Fix mdsync never-ending loop problem
Previous Message Bruce Momjian 2007-04-10 01:22:24 Re: CREATE TABLE LIKE INCLUDING INDEXES support