Re: Macros for typtype (was Re: Arrays of Complex Types)

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)
Date: 2007-04-01 00:28:54
Message-ID: 200704010228.56249.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> > I just realized that I need to check every usage of typtype to be
> > sure that the enums patch is sane. So, barring objection, I intend
> > to take this opportunity to make the code stop referring directly
> > to 'b', 'c' etc whereever possible. Any objections to these names?
> >
> > #define TYPTYPE_BASE 'b'
> > #define TYPTYPE_COMPOSITE 'c'
> > #define TYPTYPE_DOMAIN 'd'
> > #define TYPTYPE_ENUM 'e'
> > #define TYPTYPE_PSEUDO 'p'
>
> I like macros. ;-)

Why not enums? ;-)

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2007-04-01 01:30:34 pgbench transaction timestamps
Previous Message David Fetter 2007-04-01 00:22:18 Re: Macros for typtype (was Re: Arrays of Complex Types)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Dunstan 2007-04-01 01:05:48 Re: Current enums patch
Previous Message David Fetter 2007-04-01 00:22:18 Re: Macros for typtype (was Re: Arrays of Complex Types)