Re: Macros for typtype (was Re: Arrays of Complex Types)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)
Date: 2007-03-31 23:13:20
Message-ID: 200703312313.l2VNDKk07650@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> I wrote:
> > David Fetter <david(at)fetter(dot)org> writes:
> >> What parts of the code would need a once-over?
>
> > A lot :-( ... probably every place that touches typtype or typelem would
> > need at least a look. It'd be a good idea to take the opportunity to
> > start using macros for the values of typtype, as we do for relkind but
> > for some reason never adopted for typtype.
>
> I just realized that I need to check every usage of typtype to be sure
> that the enums patch is sane. So, barring objection, I intend to take
> this opportunity to make the code stop referring directly to 'b', 'c'
> etc whereever possible. Any objections to these names?
>
> #define TYPTYPE_BASE 'b'
> #define TYPTYPE_COMPOSITE 'c'
> #define TYPTYPE_DOMAIN 'd'
> #define TYPTYPE_ENUM 'e'
> #define TYPTYPE_PSEUDO 'p'

I like macros. ;-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-03-31 23:16:19 Re: Last minute mini-proposal (I know, I know)forPQexecf()
Previous Message Bruce Momjian 2007-03-31 23:12:35 Re: Last minute mini-proposal (I know, I know)forPQexecf()

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Dunstan 2007-03-31 23:18:31 Re: Current enums patch
Previous Message Tom Lane 2007-03-31 23:10:08 Macros for typtype (was Re: Arrays of Complex Types)