From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, David Fetter <david(at)fetter(dot)org> |
Subject: | Re: Macros for typtype (was Re: Arrays of Complex Types) |
Date: | 2007-04-01 02:31:26 |
Message-ID: | 13829.1175394686@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> I just realized that I need to check every usage of typtype to be
>>> sure that the enums patch is sane. So, barring objection, I intend
>>> to take this opportunity to make the code stop referring directly
>>> to 'b', 'c' etc whereever possible. Any objections to these names?
> Why not enums? ;-)
Well, macros is how we do it elsewhere for "char" system columns.
I'm not sure we could rely on the behavior if we declared
pg_type.typtype as an enum type ... and if we don't, there's not
much point.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Dilger | 2007-04-01 02:47:21 | Re: Bug in UTF8-Validation Code? |
Previous Message | Greg Smith | 2007-04-01 01:30:34 | pgbench transaction timestamps |
From | Date | Subject | |
---|---|---|---|
Next Message | Russell Smith | 2007-04-01 02:33:43 | Re: Add usage counts to pg_buffercache |
Previous Message | Greg Smith | 2007-04-01 02:20:55 | Add usage counts to pg_buffercache |