Re: WIP patch - INSERT-able log statements

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Guillaume Smet <guillaume(dot)smet(at)gmail(dot)com>
Cc: Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: WIP patch - INSERT-able log statements
Date: 2007-02-19 17:15:55
Message-ID: 20070219171555.GW28395@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Guillaume Smet escribió:
> On 2/19/07, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> >So add the session ID (%c) to log_line_prefix.
>
> It could work if log_line_prefix was added before every line but it's
> definitely not the case:
> myuser mydb 45d9d615.4abe LOG: duration : 185.223 ms, statement : SELECT *
> FROM lieu
> LIMIT 10;
> if you execute:
> SELECT *
> FROM lieu
> LIMIT 10;

Interesting. I wonder why didn't you report this as a bug before?
Maybe we could have discussed it and fixed it.

This is irrelevant in this particular discussion anyway if we introduce
SQL format, because then the newline should be part of the COPY or INSERT
data. Let's just make sure to not make the same errors again.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian G. Pflug 2007-02-19 17:16:31 Re: Confusing message on startup after a crash while recovering
Previous Message Zoltan Boszormenyi 2007-02-19 17:13:03 How can I merge a TargetEntry with a tuple?

Browse pgsql-patches by date

  From Date Subject
Next Message Guillaume Smet 2007-02-19 17:31:53 Re: [PATCHES] WIP patch - INSERT-able log statements
Previous Message Alvaro Herrera 2007-02-19 17:04:35 Re: Recalculating OldestXmin in a long-running vacuum